Re: [ATM]: refcount atm sockets

From: Muli Ben-Yehuda
Date: Fri Jan 16 2004 - 07:55:18 EST


Howdy, in this patchset for 2.4:

On Fri, Jan 16, 2004 at 10:02:24AM +0000, Linux Kernel Mailing List wrote:
> ChangeSet 1.1405.1.4, 2004/01/16 02:02:24-08:00, chas@xxxxxxxxxxxxxxxx
>
> [ATM]: refcount atm sockets

> diff -Nru a/net/atm/common.c b/net/atm/common.c
> --- a/net/atm/common.c Fri Jan 16 04:17:24 2004
> +++ b/net/atm/common.c Fri Jan 16 04:17:24 2004
> @@ -242,6 +242,8 @@
> printk(KERN_DEBUG "vcc_sock_destruct: wmem leakage (%d bytes) detected.\n", atomic_read(&sk->wmem_alloc));
>
> kfree(sk->protinfo.af_atm);
> +
> + MOD_DEC_USE_COUNT;

This has the usual wellknown races involved with handling the module's
refcount from within the moodule. Is there a way to push the
refcounting to the caller?

Cheers,
Muli
--
Muli Ben-Yehuda
http://www.mulix.org | http://mulix.livejournal.com/

"the nucleus of linux oscillates my world" - gccbot@#offtopic

Attachment: signature.asc
Description: Digital signature