Re: 2.4.22-bk30 and C trigraphs bugs

[Xose Vazquez Perez]

Randy.Dunlap wrote:

> On Thu, 09 Oct 2003 01:44:31 +0200 Xose Vazquez Perez <xose@xxxxxxxxxx> wrote:
> 
> | hi,
> | 
> | There are some mistakes with C trigraphs:
> | 
> | arch/m68k/atari/stram.c:                        PRINT_PROC( "??)\n" );
> | arch/sparc/kernel/traps.c:              die_if_kernel("Penguin instruction from Penguin mode??!?!", regs);
> | drivers/atm/idt77252.c:         printk("%s: PCI_COMMAND: %04x (???)\n",
> | drivers/acorn/scsi/acornscsi.c:    "??-out",                    /* 1C */
> | drivers/acorn/scsi/acornscsi.c:    "??-in",                     /* 1D */
> | drivers/block/acsi.c:   { 0x00, "No error (??)" },
> | drivers/block/acsi.c:   { 0x00, "No error (??)" },
> | drivers/media/video/saa7110.c:          DEBUG(printk(KERN_INFO "unknown saa7110_command??(%d)\n",cmd));
> | drivers/mtd/maps/sun_uflash.c:          name:           "SUNW,???-????",
> | drivers/scsi/ppa.c:     printk("ppa: parity error (???)\n");
> | drivers/scsi/ppa.c:     printk("ppa: bad interrupt (???)\n");
> | drivers/scsi/imm.c:     printk("imm: parity error (???)\n");
> | drivers/scsi/imm.c:     printk("imm: bad interrupt (???)\n");
> | net/rose/af_rose.c:                     callsign = "??????-?";
> | 
> | fixes are trivial.
> | 
> | Is 2.6.0-pre free of them  :-?
> 
> Of course not.  I grepped over 100 of them in 2.6.1.
> 
> Are they a problem?

Visually yes, they hurt to the sight ;-)

But unless somebody uses -std or -ansi, by default GCC
ignores trigraphs.

-- 
Software is like sex, it's better when it's bug free.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/