Re: [patch] PCI Express Enhanced Config Patch - 2.6.0-test11

[Linus Torvalds]

On Thu, 29 Jan 2004, Matthew Wilcox wrote:
> 
> Brian Gerst spotted a bug -- I'd forgotten to initialise mmcfg_virt_addr.

The compiler _should_ entirely compile away "fix_to_virt(xxx)", so by 
creating a variable for the value, you're actually making code generation 
worse. You might as well have

	#define mmcfg_virt_addr (fix_to_virt(FIX_PCIE_MCFG))

instead.

That said, this patch looks perfectly acceptable to me. With some testing, 
I'd take it through Greg or -mm.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/