RE: [PATCH] cpqarray update

From: Wiran, Francis
Date: Thu Jan 29 2004 - 11:42:17 EST



> -----Original Message-----
> From: Greg KH [mailto:greg@xxxxxxxxx]
> Sent: Wednesday, January 28, 2004 5:29 PM
> To: Wiran, Francis
> Cc: Hollis Blanchard; Marcelo Tosatti; Jeff Garzik; Linux
> Kernel Mailing List
> Subject: Re: [PATCH] cpqarray update
>
>
> On Wed, Jan 28, 2004 at 05:10:29PM -0600, Wiran, Francis wrote:
> >
> > Ok. Here's the patch for that. At least until
> vio_module_init comes :)
>
> Heh, you didn't actually try that patch, did you?
>
> (hint, you need to check for a negative value...)
>
> greg k-h
>

check for negative value? That's odd. The pci_register_driver() in my
copy of 2.4.24 kernel (drivers/pci/pci.c) looks something like this:

{
count = 0;

for ....
count += foo();

return count;
}


Or will it change in the future? The patch that I sent was based on what
is in the current kernel.




Just for clarification:
I sent two patches yesterday (I should've numbered them, sorry I
forgot), since they address different issues and the driver registration
issue is being discussed right now.
First patch was cpqarray_eisa_detect_fix.patch, second was
cpqarray_pci_unregister.patch
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/