Re: [TRIVIAL PATCH] 2.4.25pre7 warning fix

[Krzysztof Halasa]

Marcelo Tosatti <marcelo.tosatti@xxxxxxxxxxxx> writes:

> Btw, why do we need cyclone_setup() for !CONFIG_X86_SUMMIT ?
>
> /* No-cyclone stubs */
> #ifndef CONFIG_X86_SUMMIT
> int __init cyclone_setup(char *str)
> {
>         printk(KERN_ERR "cyclone: Kernel not compiled with
> CONFIG_X86_SUMMIT, cannot use the cyclone-timer.\n");
>         return 1;
> }

After having a closer look at it I think we should:

1. if CONFIG_X86_TSC is set:
   - make calibrate_tsc() failure a fatal error
   - assume use_tsc = 1 and x86_udelay_tsc = 1 and optimize them out
     with preprocessor

2. if CONFIG_X86_SUMMIT is _not_ set:
   - assume use_cyclone = 0 and optimize it out as well.
   - cyclone_setup() etc should go out.

3. I would rename CONFIG_X86_TSC to something like CONFIG_X86_TSC_FORCE
   - the current name is misleading. It wouldn't affect .config.

This is all 2.4-only, as 2.6 is a little different here.

Comments?
-- 
Krzysztof Halasa, B*FH
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/