Re: 2.6.2-rc2-mm1

[Zephaniah E. Hull]

On Tue, Jan 27, 2004 at 11:34:02PM -0800, Andrew Morton wrote:
> 
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.2-rc2/2.6.2-rc2-mm1/
> 
> - From now on, -mm kernels will contain the latest contents of:
> 
> 	Vojtech's tree:		input.patch

This one seems to have a rather problematic patch, which I can't find
any explanation for.

Specificly:
<snip>
diff -Nru a/drivers/usb/input/hid-input.c b/drivers/usb/input/hid-input.c
--- a/drivers/usb/input/hid-input.c	Thu Jan 29 22:57:25 2004
+++ b/drivers/usb/input/hid-input.c	Thu Jan 29 22:57:25 2004
@@ -432,20 +432,21 @@
 	input_regs(input, regs);
 
 	if ((hid->quirks & HID_QUIRK_2WHEEL_MOUSE_HACK)
-			&& (usage->code == BTN_BACK)) {
+			&& (usage->code == BTN_BACK || usage->code == BTN_EXTRA)) {
 		if (value)
 			hid->quirks |= HID_QUIRK_2WHEEL_MOUSE_HACK_ON;
 		else
 			hid->quirks &= ~HID_QUIRK_2WHEEL_MOUSE_HACK_ON;
 		return;
 	}
<snip>

This seems to be due to trying to use the same flag for
USB_DEVICE_ID_CYPRESS_MOUSE as well, however this is very wrong.

The original user of HID_QUIRK_2WHEEL_MOUSE_HACK,
USB_DEVICE_ID_A4TECH_WCP32PU, actually /HAS/ a button labeled BTN_EXTRA,
which after this patch can no longer even be used.

The only proper approach is to rename HID_QUIRK_2WHEEL_MOUSE_HACK and
add a new one for the Cypress mouse as well.

If need be I can generate such a patch, however I will need to know what
to generate it against.

Zephaniah E. Hull.
(Original author of the HID_QUIRK_2WHEEL_MOUSE_HACK patch.)

-- 
	1024D/E65A7801 Zephaniah E. Hull <warp@xxxxxxxxxxxxxxxx>
	   92ED 94E4 B1E6 3624 226D  5727 4453 008B E65A 7801
	    CCs of replies from mailing lists are requested.

If I have trouble installing Linux, something is wrong. Very wrong.
  -- Linus Torvalds on l-k.

Attachment: signature.asc
Description: Digital signature