Re: Lindent fixed to match reality

From: Linus Torvalds
Date: Fri Jan 30 2004 - 11:39:53 EST




On Thu, 29 Jan 2004, Krzysztof Halasa wrote:
> Erik Hensema <erik@xxxxxxxxxxx> writes:
>
> >> void *foo(void) {
> >>
> >> instead of
> >>
> >> void *
> >> foo(void) {
> >
> > You just nicely broke 'find . -name *.c | xargs grep ^foo'.
>
> It was never working with the kernel, so no one can break it.
> Just use a little better pattern or use a tool which parses C code.

Indeed.

Never _ever_ make your source-code look worse because your tools suck. Fix
the tools instead.

There are tons of tools that index sources properly, so please don't try
to make code look like crap because of using broken things like '^foo'.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/