Re: 2.6.2-rc3 broke ptrace in the vsyscall dso area

From: Daniel Jacobowitz
Date: Mon Feb 02 2004 - 10:40:32 EST


On Sun, Feb 01, 2004 at 09:43:42PM -0800, Roland McGrath wrote:
> > Any idea what might have disabled this?
>
> ...Mosberger!! When Andrew asked me to sign off on David's rework of that
> code, I did so with the caveat that it be tested on i386 before being
> accepted, and evidently it never was.
>
> The #include is the part of this patch that matters, so the #ifdef below
> works. (Frankly, I have never seen the rationale for conditionalizing this
> code on AT_SYSINFO_EHDR rather than just FIXADDR_USER_START. But David
> wanted it that way and Andrew approved it.) The rest of the patch removes
> gratuitous duplication due to some strange aversion to concision in the
> presence of #ifdef, the kind that is all too common, utterly pointless, and
> error prone.

Thanks, adding <linux/elf.h> makes GDB much happier.

--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/