Re: Patch to get cpqphp working with IOAPIC (2.6.0-test5)

From: Greg KH
Date: Mon Feb 02 2004 - 15:25:10 EST


On Tue, Sep 16, 2003 at 08:50:24AM -0700, Dely Sy wrote:
> Hi,
>
> Here is a patch for 2.6.0-test5 to get cpqphp working with IOAPIC.
> My earlier statement that a kernel patch is not needed for 2.6 is
> true only when ACPI is enabled. A similar patch is needed in
> pcibios_enable_irq() for 2.4 kernel and I will send it out
> later.
>
> The fix is in pirq_enable_irq(). This function is called indirectly
> by pci_enable_device(). For device present during boot up, it should
> get the proper dev->irq for pcibios_fixup_irqs() has been called to
> get the dev->irq from MP table. If the value is still zero, then
> this is properly caused by "buggy MP table". For hot-plug device,
> its dev->irq is 0 when the pci_enable_device() is called for it hasn't
> gone through the fixup. Therefore, the code (similiar to the code
> in pcibios_fixup_irqs) is needed here.

Wow, very sorry for the long delay here. I took the patch you sent me
for the irq.c file in your previous big SHPC patch and added it to the
rest of the cpqphp changes you made here, and applied it to my trees.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/