Re: [PATCH] Driver for IBM RSA service processor (1/2)

[Andi Kleen]

Max Asbock <masbock@xxxxxxxxxx> writes:
> +
> +#define IBMASM_IOCTL_MAGIC	'f'
> +#define IBMASM_IO_CANCEL	_IO(IBMASM_IOCTL_MAGIC, 0)

Can you please move that into some file in include/linux ?  IMHO all
ioctls should be in some header, otherwise nobody knows you reserved
the number. Note that ioctl numbers must be unique in Linux. Also it
would be good if you added an
register_ioctl32_conversion(IBMASM_IOCTL_MAGIC, sys_ioctl) or an
COMPATIBLE_IOCTL in compat_ioctl.h for it to make it transparently
work with the 32bit emulation layers.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/