Re: [PATCH] Sun Keyboard driver

[Vojtech Pavlik]

On Wed, Feb 04, 2004 at 12:51:28PM +0100, Erlend Aasland wrote:
> Hi,
> 
> I noticed a small bug in the sunkbd.c driver: After the keyboard name is
> set, it is mistakenly overwritten by serio->phys. Path is against 2.6.2.

Thanks for noticing, it's already fixed in my tree.

> 
> Regards,
> 		Erlend Aasland
> 
> --- drivers/input/keyboard/sunkbd.c~	2004-02-04 13:06:44.603610000 +0100
> +++ drivers/input/keyboard/sunkbd.c	2004-02-04 13:09:00.603610000 +0100
> @@ -275,7 +275,7 @@
>  		set_bit(sunkbd->keycode[i], sunkbd->dev.keybit);
>  	clear_bit(0, sunkbd->dev.keybit);
>  
> -	sprintf(sunkbd->name, "%s/input", serio->phys);
> +	sprintf(sunkbd->phys, "%s/input", serio->phys);
>  
>  	sunkbd->dev.name = sunkbd->name;
>  	sunkbd->dev.phys = sunkbd->phys;
> 

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/