Re: [Bugme-new] [Bug 2019] New: Bug from the mm subsystem involvingX (fwd)

From: Linus Torvalds
Date: Wed Feb 04 2004 - 19:50:44 EST




On Wed, 4 Feb 2004, Martin J. Bligh wrote:
>
> Oh hell ... I remember what's wrong with this whole bit. pfn_valid is
> used inconsistently in different places, IIRC. Linus / Andrew ... what
> do you actually want it to mean? Some things seem to use it to say
> "the memory here is valid accessible RAM", some things "there is a
> valid struct page for this pfn". I was aiming for the latter, but a
> few other arches seemed to disagree.
>
> Could I get a ruling on this? ;-)

It _definitely_ means "there is a valid 'struct page' for this pfn".

To test for "there is RAM" here, you need to first check that the pfn is
valid, and then you can check what the page type is (usually that would be
PageReserved(), but it could be a highmem check or something like that
too).

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/