Re: [PATCH 2.6.2-rc3-mm1] DIO read race fix

[Suparna Bhattacharya]

On Wed, Feb 04, 2004 at 07:19:21PM -0800, Andrew Morton wrote:
> Janet Morgan <janetmor@xxxxxxxxxx> wrote:
> >
> > >Daniel McNeil <daniel@xxxxxxxx> wrote:
> >  >  
> >  >
> >  >>I have found (finally) the problem causing DIO reads racing with
> >  >>buffered writes to see uninitialized data on ext3 file systems 
> >  >>(which is what I have been testing on).
> >  >>    
> >  >>
> >  >
> >  >What kernel?  If -mm, is this the only remaining buffered-vs-direct
> >  >problem?
> >  >
> >  >  
> >  >
> >  I think there was consensus on two other patches along the way:
> > 
> >      http://marc.theaimsgroup.com/?l=linux-kernel&m=107286971311559&w=2
> >      http://marc.theaimsgroup.com/?l=linux-aio&m=107291089712224&w=2
> 
> Yes, I think those are needed but this thing has been dragging on for so
> long it has become a little unclear.  This was the main reason why I backed
> off the fs-aio patches.
> 
> Daniel, could you please work out whether we actually need those patches
> and if so, prep them for us?  Presumably if ext2 passes all testing without
> those patches, we do not need them.

I think we agreed from a logical standpoint that those patches are correct
and needed, didn't we ?

Whether or not we encounter those races in our testing is to a certain
extent a matter of chance. I wouldn't use passing of all tests for ext2 
as a proof that they aren't needed. It just tells us that they may be
less likely.

Regards
Suparna

-- 
Suparna Bhattacharya (suparna@xxxxxxxxxx)
Linux Technology Center
IBM Software Lab, India

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/