[PATCH] 2.6.2-mm1 - more -Wundef cleanup

From: Valdis . Kletnieks
Date: Thu Feb 05 2004 - 22:53:39 EST


Even after the patch I just sent, building with -Wundef still gets:

CC drivers/char/mem.o
In file included from drivers/char/mem.c:15:
include/linux/ftape.h:168:7: warning: "CONFIG_FT_ALT_FDC" is not defined

#elif CONFIG_FT_ALT_FDC == 1 /* CONFIG_FT_MACH2 */

The sort of whoops that -Wundef was intended to catch.

Further research shows that it's spurious - there's no obvious
reason for mem.c to even include ftape.h (or tpquic02.h for that
matter) - compiles fine, even compared 'gcc -E' with and without.

--- linux-2.6.2-mm1/drivers/char/mem.c.dist 2004-02-05 22:23:34.291328515 -0500
+++ linux-2.6.2-mm1/drivers/char/mem.c 2004-02-05 22:36:25.900847264 -0500
@@ -11,8 +11,6 @@
#include <linux/config.h>
#include <linux/mm.h>
#include <linux/miscdevice.h>
-#include <linux/tpqic02.h>
-#include <linux/ftape.h>
#include <linux/slab.h>
#include <linux/vmalloc.h>
#include <linux/mman.h>

Attachment: pgp00000.pgp
Description: PGP signature