Re: dmapool (was: Re: Linux 2.6.3-rc2)

From: Geert Uytterhoeven
Date: Tue Feb 10 2004 - 09:35:05 EST


On Tue, 10 Feb 2004, Geert Uytterhoeven wrote:
> The dmapool code makes dma_{alloc,free}_coherent() a requirement for all
> platforms, breaking platforms that don't have it (e.g. m68k, and from a quick
> browse sparc and sparc64 probably, too).
>
> May not be that nice for a release candidate in a stable series...

This patch seems to fix the problem (all offending platforms include
<asm/generic.h> if CONFIG_PCI only):

--- linux-2.6.3-rc2/drivers/base/Makefile 2004-02-10 11:14:46.000000000 +0100
+++ linux-m68k-2.6.3-rc2/drivers/base/Makefile 2004-02-10 15:23:13.000000000 +0100
@@ -2,7 +2,8 @@

obj-y := core.o sys.o interface.o bus.o \
driver.o class.o class_simple.o platform.o \
- cpu.o firmware.o init.o map.o dmapool.o
+ cpu.o firmware.o init.o map.o
obj-y += power/
obj-$(CONFIG_FW_LOADER) += firmware_class.o
obj-$(CONFIG_NUMA) += node.o
+obj-$(CONFIG_PCI) += dmapool.o

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/