Re: [PATCH] [2.6] [1/2] hlist: replace explicit checks of hlistfields w/ func calls

From: Andi Kleen
Date: Wed Feb 11 2004 - 02:51:13 EST


On Tue, 10 Feb 2004 22:57:43 -0800
Alex Pankratov <ap@xxxxxxxxxx> wrote:

> Ugh, yeah, I thought about this. However my understand was that
> since hlist_null is statically allocated variable, its address
> will be a known constant at a link time (whether it's a static
> link or dynamic/run-time link - btw, excuse my lack of proper
> terminology here). So comparing something to &null would be
> equivalent to comparing to the constant and not require an
> extra register.

Hmm, you're right. Apparently I was still thinking about the bad
code generated by the standard list_heads. I guess it would be ok then.

Still your first patch was rather intrusive regarding interface changes,
so it may be a good idea to wait for 2.7 with this.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/