Re: [Patch] Netlink BUG() on AMD64

[YOSHIFUJI Hideaki / 吉藤英明]

In article <20040211181113.GA2849@xxxxxxxxxx> (at Wed, 11 Feb 2004 19:11:14 +0100), Jan Kasprzak <kas@xxxxxxxxxxxxxxxxxxx> says:

> 	I suggest the following patch, but all occurences of
> nlmsg_failure: and rtattr_failure: labels should be checked for a similar
> problem.
> 
> --- linux-2.6.2/net/ipv4/fib_rules.c.orig	2004-02-11 18:55:58.000000000 +0100
> +++ linux-2.6.2/net/ipv4/fib_rules.c	2004-02-11 19:03:08.319215408 +0100
> @@ -438,7 +438,7 @@
>  
>  nlmsg_failure:
>  rtattr_failure:
> -	skb_put(skb, b - skb->tail);
> +	skb_trim(skb, b - skb->data);
>  	return -1;
>  }
>  
> Please apply or let me know what the proper fix should be.

looks good to me.
Other places including net/ipv6/{addrconf.c,route.c} seems okay.

--yoshfuji
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/