Re: [PATCH] bogus __KERNEL_SYSCALLS__ usage

[Johannes Stezenbach]

Dave Jones wrote:
> I just did a mini-audit of users of __KERNEL_SYSCALLS and turned
> up a bunch of uglies. The patch below is the easy ones
> (nothing to fix, they were defining it and including unistd.h for no reason).
> The remainders will need more work.
...
> 	drivers/media/dvb/frontends/tda1004x.c:#define __KERNEL_SYSCALLS__
> 	drivers/media/dvb/frontends/sp887x.c:#define __KERNEL_SYSCALLS__
> 	drivers/media/dvb/frontends/alps_tdlb7.c:#define __KERNEL_SYSCALLS__
> 
> Joy joy. Implementing their own firmware loaders by directly
> reading files into kernel space. Icky.

Old code, implemented before request_firmware() existed.

The problem is that the current dvb_i2c stuff has no direct access
to a sysfs struct device, which is necessary for request_firmware().
Possible solutions have briefly been discussed on the linux-dvb list,
one of them ditching dvb_i2c in favor of the kernel i2c subsystem.

So please be patient, work is under way. See also
Documentation/dvb/firmware.txt.


Johannes
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/