Re: [Patch] dma_sync_to_device

[Jamie Lokier]

David S. Miller wrote:
> It is different.  pci_dma_sync_single(..., DMA_TO_DEVICE), on MIPS for example,
> would do absolutely nothing.  At mapping time, the local cpu cache was flushed,
> and assuming the MIPS pci controllers don't have caches of their own there is
> nothing to flush there either.
> 
> Whereas pci_dma_sync_device_single() would flush the dirty lines from the cpu
> caches.  In fact, it will perform the same CPU cache flushes as pci_map_single()
> did, using MIPS as the example again.

The names are a bit confusing.
How about changing them to:

    pci_dma_sync_single         => pci_dma_sync_for_cpu
    pci_dma_sync_device_single  => pci_dma_sync_for_device

-- Jamie
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/