Re: new driver (hvcs) review request and sysfs questions

From: Greg KH
Date: Tue Feb 24 2004 - 20:32:26 EST


On Tue, Feb 24, 2004 at 06:00:26PM -0600, Ryan Arnold wrote:
> An example of the vio bus's "devices" sysfs directory is shown below.
>
> Pow5:/sys/bus/vio/devices # ls
> . l-lan@3000000c l-lan@30000010 vty-server@30000004
> .. l-lan@3000000d rtc@4001 vty@30000000
> IBM,sp@4000 l-lan@3000000e v-scsi@30000002
> l-lan@3000000b l-lan@3000000f vty-server@30000003

At first glance, why are you using text strings as part of your bus ids?
Bus ids must be unique, so it looks like you can do this by just using
the number after the '@' character, right?

Then, within each device on the bus, you can give it a "name" or "type"
if you want. You can put the "l-lan", "rtc", "vty*" stuff there, and
not encode it in the bus id (which is not where it belongs.)

> P.S. who is maintainer of the char device tree?

Do you mean /drivers/char? Not really anyone directly. Do you have
some char drivers that need to get added there? What type of drivers
are they?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/