Re: [Kgdb-bugreport] Re: kgdb: rename i386-stub.c to kgdb.c
From: George Anzinger
Date: Wed Feb 25 2004 - 16:23:34 EST
Pavel Machek wrote:
Hi!
kgdb uses really confusing names for arch-dependend parts. This fixes
it. Okay to commit?
Why is arch/$x/kernel/$x-stub.c confusing? The name $x-stub.c is indicative of
architecture dependent code in it. Err, well so is the path.
Well, looking at i386-stub.c, how do you know it is kgdb-related?
PPC and sparc stubs in present vanilla kernel use this naming convention.
That's why I adopted it.
I find kernel/kgdbstub.c, arch/$x/kernel/$x-stub.c more consistent compared to
kernel/kgdbstub.c, arch/$x/kernel/kgdb.c
I actually made it kernel/kgdb.c and arch/*/kernel/kgdb.c. I believe
there's no point where one could be confused....
gdb itself gets confused with this. Try, for example, time.c which, on the x86,
is in both arch and common code. I use emacs with kgdb and it gets confused
when I point at a location in the source and tell it to set a break point.
Please, lets have only one of each name.
--
George Anzinger george@xxxxxxxxxx
High-res-timers: http://sourceforge.net/projects/high-res-timers/
Preemption patch: http://www.kernel.org/pub/linux/kernel/people/rml
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/