Re: [PATCH] Clean up sys_ioperm stubs

From: Andrew Morton
Date: Wed Feb 25 2004 - 22:14:24 EST


viro@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx wrote:
>
> On Wed, Feb 25, 2004 at 09:51:30PM -0500, Brian Gerst wrote:
> > Remove stubs for sys_ioperm for non-x86 arches, using sys_ni_syscall
> > instead where applicable.
>
> I have better suggestion: make sys_ioperm() a cond_syscall(). Then kill
> its implementation on all platforms where it just returns -ENOSYS.

Why is that better? Sticking a pointer to the not-implemented-syscall into
the syscall table is pretty darn explicit.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/