Re: bio_put oopses in 2.6.3-mm3 when resyncing reiserfs/raid1

[Neil Brown]

On Friday February 27, thunder7@xxxxxxxxx wrote:
> I got this in 2.6.3-mm3 when rsyncing my reiserfs on raid1 system.
> The taint is vmware (with the latest vmware-any-any updates) but X
> hadn't been started, let alone vmware. It happened multiple times,
> until I rebooted 2.6.3-mm1 and all was fine again. I don't see any
> patches in 2.6.3-mm4 that would solve this, and I couldn't find any
> similar reports on lkml.

Thanks for the report.  This patch should fix the problem.

NeilBrown


 ----------- Diffstat output ------------
 ./drivers/md/raid1.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff ./drivers/md/raid1.c~current~ ./drivers/md/raid1.c
--- ./drivers/md/raid1.c~current~	2004-02-24 11:49:11.000000000 +1100
+++ ./drivers/md/raid1.c	2004-02-28 08:44:05.000000000 +1100
@@ -104,8 +104,8 @@ out_free_pages:
 	for ( ; i > 0 ; i--)
 		__free_page(bio->bi_io_vec[i-1].bv_page);
 out_free_bio:
-	while ( j < raid_disks )
-		bio_put(r1_bio->bios[++j]);
+	while ( ++j < raid_disks )
+		bio_put(r1_bio->bios[j]);
 	r1bio_pool_free(r1_bio, data);
 	return NULL;
 }
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/