Re: kgdb: fix kgdbeth compilation and make it init late enough

From: George Anzinger
Date: Tue Mar 02 2004 - 20:07:21 EST


Tom Rini wrote:
On Tue, Mar 02, 2004 at 11:28:27PM +0100, Pavel Machek wrote:


Hi!


CONFIG_NO_KGDB_CPUS can not be found anywhere in the patches => its
probably not needd any more.

I don't know if we can do that. There's some funky locking stuff done
on SMP, which for some reason can't be done to NR_CPUS (or, no one has
tried doing that).

There was no CONFIG_NO_KGDB_CPUS anywhere else in the CVS, that means
that test could not have been right.


That doesn't mean the right answer is to remove it. However, after
talking with George (who might speak up now anyhow) for 2.6 we can just
do the SMP locking stuff at NR_CPUS, since that's configurable.

The old CONFIG_NO_KGDB_CPUS only affected the kgdb_info array. Its only purpose was to shorten the array as it I displayed it fairly often and having a bunch of unused stuff at the end was a bother. Now that 2.6 lets you define this, it is no longer needed.



--
George Anzinger george@xxxxxxxxxx
High-res-timers: http://sourceforge.net/projects/high-res-timers/
Preemption patch: http://www.kernel.org/pub/linux/kernel/people/rml

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/