Re: Mysterious string truncation in 2.4.25 kernel

[James Morris]

On Wed, 3 Mar 2004, Marcelo Tosatti wrote:

> 
> 
> On Wed, 3 Mar 2004, James Morris wrote:
> 
> > On Tue, 2 Mar 2004, Glen Nakamura wrote:
> > 
> > > Of course, perhaps 0 should passed instead of "" for data_page?
> > > 
> > > -    err = do_mount ("none", "/dev", "devfs", 0, "");
> > > +    err = do_mount ("none", "/dev", "devfs", 0, 0);
> > >
> > > Comments?
> > 
> > Yes, the devfs fix above is needed if the data_page patch has been 
> > applied.  
> > 
> > This is the case in 2.6, but not 2.4.25.
> 
> My bad :(
> 
> Changed last argument of fs/devfs/base.c do_mount() call to NULL, as per 
> 2.6.
> 
> James, wonder if your change can't cause other similar problems in 2.4? 

Looks like sunos_nfs_mount() needs to be fixed to pass a page as the last 
argument of do_mount().


- James
-- 
James Morris
<jmorris@xxxxxxxxxx>


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/