Re: powernow-k8-acpi driver

From: Pavel Machek
Date: Wed Mar 03 2004 - 17:37:04 EST


On St 03-03-04 22:27:12, Dave Jones wrote:
> On Wed, Mar 03, 2004 at 10:54:36PM +0100, Pavel Machek wrote:
> > Hi!
> >
> > Lots of machines have broken PST tables, so current in-kernel driver
> > refuses to works on them. Vendors do get ACPI tables right because
> > apparently Windows use them ;-). So this driver tends to work.
> >
> > Comments? Could we get this into mainline?
>
> I really dislike the idea of having >1 driver for this.
> Why can't we have a "use_acpi" module_param to switch to this ?

Well, that would probably not even link on kernel without ACPI...

We could make that functionality depend on CONFIG_ACPI, and allow
runtime selection only if its defined... But those two drivers are
pretty different just now and acpi-dependend chunk is pretty big. (It
does funny stuff like polling for AC plug removal if we are in
high-power state and battery would not handle that. Old driver simply
refused to use high-power states on such machines.)

Pavel
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/