Re: Linux 2.4.26-pre2

From: Rene Herman
Date: Sun Mar 07 2004 - 14:54:39 EST


David Weinehall wrote:

In standard C we declare all variables at the top of a function. While
some compilers allow extension, it is not a good idea to get used to
them if we want portable code.

Oh, come on. This is _kernel_ code, it won't ever be compiled with anything
not GCC-compatible.

Ugly warts don't become any less ugly just because gcc accepts them...

Mixing code and declarations is also c99. For (a sane) gcc specifically, you have to tell it -std=c89 -pedantic to have it even complain.

Rene.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/