Re: [PATCH] ipt_helper.c

From: Bill Davidsen
Date: Tue Mar 09 2004 - 14:47:56 EST


quadong@xxxxxxxxxxxxxxxxxxxxx wrote:
Currently, if you tell iptables to match "-m helper ! --helper ftp" it
will match any packet from any helper other than FTP. What it should do
is match any packet that is not from an FTP helper, included packets that
are not from any helper (packets from master connections). Here's the
fix:

--- ipt_helper.c.old 2004-03-03 21:34:05.000000000 -0600
+++ ipt_helper.c 2004-03-04 14:34:17.709903456 -0600
@@ -48,7 +48,7 @@

if (!ct->master) {
DEBUGP("ipt_helper: conntrack %p has no master\n", ct);
- return 0;
+ return info->invert;
}

exp = ct->master;

I think you can get the functionality you want with the current code, but can you get the current functionality which you feel is in error after applying your patch?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/