Re: [2.6.4-rc2] bogus semicolon behind if()

[Zwane Mwaikambo]

On Wed, 10 Mar 2004, Philippe Elie wrote:

> > 1. The semicolons behind the if()'s cannot be there intentionally.
> > 2. To fix my problem, timer_ack must be set to 1 for my (integrated) APIC, and
> > as my CPU has a TSC, this cannot be correct for me:
> > -	timer_ack = 1;
> > +	if (nmi_watchdog == NMI_IO_APIC && !APIC_INTEGRATED(ver))
> > +		timer_ack = 1;
> > +	else
> > +		timer_ack = !cpu_has_tsc;
>
> I don't get the figure, this code in check_timer() is called by
> setup_IO_APIC so APIC_INTEGRATED(ver) is always 0 ?

Nope, that will catch the older external "local" APICs like the 82489s (P5
etc), most IOAPICs will return 0x11 or higher for version#
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/