Re: 2.6.4-rc2-mm1: IPMI_SMB doesnt compile

[Corey Minyard]

Greg KH wrote:

> On Wed, Mar 10, 2004 at 07:51:05PM +0100, Adrian Bunk wrote:
>  
>
> > On Wed, Mar 10, 2004 at 10:01:07AM -0600, Corey Minyard wrote:
> >    
> >
> > > ...
> > > I have included a patch from Todd Davis at Intel that adds this function 
> > > to the I2C driver.  I believe Todd has been working on getting this in 
> > > through the I2C driver writers, although the patch is fairly non-intrusive.
> > >
> > > However, I have no real way to test this patch.
> > > ...
> > >      
> > I can only confirm that it fixes the compilation...
> >
> >
> > The patch to i2c-core.c is strange:
> >    
>
> And dumb, and incorrect :(
>
>  
Wrong as in: "This code will not work" or wrong as in: "don't export the 
variable and the function", or both?  I certainly agree that exporting 
both is wrong, there should really be two inline functions with only the 
variable exported, or only functions exported and the variable hidden.  
That's an easy change.

However, if the code does not work, that is a bigger deal.  I'm fairly 
sure it works in some cases, but not sure about all.

The patch I posted is for 2.6, BTW.

-Corey

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/