Re: [PATCH] per-backing dev unplugging #2

[Ingo Oeser]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Jens,

On Thursday 11 March 2004 09:36, Jens Axboe wrote:
> diff -ur -X /home/axboe/cdrom/exclude /opt/kernel/linux-2.6.4-mm1/kernel/power/pmdisk.c linux-2.6.4-mm1/kernel/power/pmdisk.c
> --- /opt/kernel/linux-2.6.4-mm1/kernel/power/pmdisk.c	2004-03-11 03:55:28.000000000 +0100
> +++ linux-2.6.4-mm1/kernel/power/pmdisk.c	2004-03-11 09:07:12.000000000 +0100
> @@ -859,7 +859,6 @@
>  
>  static void wait_io(void)
>  {
> -	blk_run_queues();
>  	while(atomic_read(&io_done))
>  		io_schedule();
>  }
> @@ -895,6 +894,7 @@
>  		goto Done;
>  	}
>  
> +	rw |= BIO_RW_SYNC;
>  	if (rw == WRITE)
>  		bio_set_pages_dirty(bio);
>  	start_io();

These last 3 lines look bogus. The condition will never trigger. 
Maybe you meant to move the assignment either down or change bio->bi_rw
instead of rw.

Regards

Ingo Oeser

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAUVuMU56oYWuOrkARAlxlAJ0Su6cddbBEu6j4lg9s880ZGI7YhQCgiXYU
zxumQHLdGy/UcBIbx56IG1k=
=vbeO
-----END PGP SIGNATURE-----
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/