Re: [SPARC64][PPC] strange error ..

[Randy.Dunlap]

On Mon, 15 Mar 2004 13:43:46 -0700 Tom Rini wrote:

| On Mon, Mar 15, 2004 at 12:39:53PM -0800, David S. Miller wrote:
| 
| > On Mon, 15 Mar 2004 12:00:26 -0700
| > Tom Rini <trini@xxxxxxxxxxxxxxxxxxx> wrote:
| > 
| > > That leaves the more general problem of <asm/unistd.h> uses 'asmlinkage'
| > > on platforms where either (or both) of the following can be true:
| > > - 'asmlinkage' is a meaningless term, and shouldn't be used.
| > > - <asm/unistd.h> doesn't include <linux/linkage.h> so it's possible
| > >   another file down the line breaks.
| > 
| > I think the best fix is to include linux/linkage.h in asm/unistd.h as
| > you seem to be suggesting, and therefore that is the change I will
| > push off to Linus to fix this on sparc32 and sparc64.
| 
| Erm, if I read include/asm-sparc{,64}/linkage.h right, 'asmlinkage' ends
| up being defined to ''.  So why not just remove 'asmlinkage' from the
| offending line in unistd.h ?

For future-proofing:  so that it will be like all other $arch/unistd.h,
so that when someone changes the meaning of it, it will just work...?

--
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/