Re: Sound core broken on sparc64 (2.6.4+bk)

[Takashi Iwai]

At Tue, 16 Mar 2004 15:28:00 +0200 (EET),
Meelis Roos wrote:
> 
> > the attached patch should fix.
> 
> Yes, thanks! This is also fixed in mainline by now.
> 
> Ths leads me to the next error:
> 
> sound/sparc/cs4231.c: In function `snd_cs4231_pcm':
> sound/sparc/cs4231.c:1573: error: `SNDRV_DMA_TYPE_PCI' undeclared (first use in this function)
> sound/sparc/cs4231.c:1573: error: (Each undeclared identifier is reported only once
> sound/sparc/cs4231.c:1573: error: for each function it appears in.)
> sound/sparc/cs4231.c:1575: error: parse error before numeric constant
> 
> SNDRV_DMA_TYPE_PCI used to be defined in <sound/memalloc.h> but is now
> gone.

grrr, it's a typo of SNDRV_DMA_TYPE_DEV.
thanks for the report.


Takashi
--- linux/sound/sparc/cs4231.c	6 Mar 2004 17:30:24 -0000	1.10
+++ linux/sound/sparc/cs4231.c	16 Mar 2004 13:40:15 -0000
@@ -1570,7 +1570,7 @@
 
 #ifdef EBUS_SUPPORT
 	if (chip->flags & CS4231_FLAG_EBUS) {
-		snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_PCI,
+		snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV,
 						      snd_dma_pci_data(chip->dev_u.pdev)
 						      64*1024, 128*1024);
 	} else {