Re: [PATCH] Driver Core update for 2.6.4

[Andi Kleen]

Andrew Morton <akpm@xxxxxxxx> writes:
>
> eh?  If there is any argument against this code it is that it is so simple
> that the thing which it abstracts is not worth abstracting.  But given that
> it is so unwasteful, this seems unimportant.

The bloat argument was about the additional pointer in the dynamic 
data structure (on a 64bit architecture it costs 12 bytes) 

Better would be to pass the callback to kref_put(), but then it would
be even better to just test the return value (callbacks are obfuscation
and should be avoided when not needed)

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/