RE: Wacom USB driver patch

[Ping Cheng]

Here is the history. Patches for wacom.c in 2.4 was majorly modified by John
Joganic. Specially, the reset thread was added by John to deal with the case
when the tablet is set/reset to HID mode. Otherwise the driver will have to
be reloaded. The code was tested by users. Patches for wacom.c in 2.6 was
made by myself.

The reason I didn't add the reset thread to 2.6 patch was because I don't
know exactly how to do it in 2.6 and I didn't find proper examples from
other device drivers in 2.6. Basically, I don't want to introduce any new
"feature" before I can convince myself.

The reason I didn't remove the reset thread code in 2.4 was because it was
tested by many users and there are no negative feedbacks. 

So, we need the reset thread. Please let me know the proper approach to
implement this feature in 2.4 and 2.6. I'll update the patches accordingly.

Ping

-----Original Message-----
From: Vojtech Pavlik [mailto:vojtech@xxxxxxx] 
Sent: Wednesday, March 17, 2004 12:37 PM
To: Pete Zaitcev
Cc: Ping Cheng; linux-kernel@xxxxxxxxxxxxxxx
Subject: Re: Wacom USB driver patch


On Wed, Mar 17, 2004 at 09:29:59AM -0800, Pete Zaitcev wrote:

> Dear Ping,
> 
> Vojtech posted your 2.6 patch to linux-kernel yesterday, so I examined 
> it
> (Subject: [PATCH 32/44] Update of Wacom driver from Ping Cheng (from
Wacom)).
> Unlike the 2.4 version, it does not feature a reset thread. Please tell
> me why that thread was required in 2.4.
> 
> Or perhaps it was present in your original submission which I lost and 
> Vojtech removed that element of the patch?

I didn't remove it - it was not present in the 2.6 patch.

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/