Re: 2.6.4-mm2

From: Chris Mason
Date: Wed Mar 17 2004 - 18:28:59 EST


On Wed, 2004-03-17 at 18:09, Andrew Morton wrote:
> Chris Mason <mason@xxxxxxxx> wrote:
> >
> > wait_on_page_writeback_range() does a pagevec_lookup_tag on
> > min(end - index + 1, (pgoff_t)PAGEVEC_SIZE)
> >
> > Which translates to: (unsigned long)-1 - 0 + 1, which is 0.
>
> I made a mental note to test that code.
>
> How's this look?
>

Looks good, but I'm still having problems convincing pagevec_lookup_tag
to return anything other than 0 when called from
wait_on_page_writeback_range (ext2, ext3, reiserfs). Any ideas?

I'm running with all the fixes discussed so far, including
clear_page_dirty_for_io(page)

-chris


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/