Re: [PATCH 9/44] Support for scroll wheel on Office keyboards

[Vojtech Pavlik]

On Tue, Mar 16, 2004 at 01:46:59PM -0500, Aubin LaBrosse wrote:

> > @@ -52,6 +52,10 @@
> >  module_param_named(softrepeat, atkbd_softrepeat, bool, 0);
> >  MODULE_PARM_DESC(softrepeat, "Use software keyboard repeat");
> >  
> > +static int atkbd_scroll;
> > +module_parm_named(scroll, atkbd_scroll, bool, 0);
> > +MODULE_PARM_DESC_(scroll, "Enable scroll-wheel on office keyboards");

>    ^^forgive me if i am wrong, but should that not be
> module_param_named, like the rest? (eg the second 'a' is missing). 
> also, why MODULE_PARM_DESC_ instead of MODULE_PARM_DESC? (extra
> underscore)

It's a bug, but it's fixed in the next changeset (also submitted). It
wouldn't even compile. You can check that it's correct in the final
file.

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/