Re: [Linux-fbdev-devel] Re: [PATCH] Sysfs for framebuffer

From: Kronos
Date: Sat Mar 20 2004 - 16:56:24 EST


Il Sat, Mar 20, 2004 at 01:30:30PM -0800, Greg KH ha scritto:
> On Sat, Mar 20, 2004 at 06:49:56PM +0100, Kronos wrote:
> > Hi,
> > the following patch (against 2.6.5-rc2) teaches fb to use class_simple.
> > With this patch udev will automagically create device nodes for each
> > framebuffer registered. Once all drivers are converted to
> > framebuffer_{alloc,release} we can switch to our own class.
>
> yeah, it's about time! Didn't I post this patch a few months ago... :)

Hum, I remeber your patch that did the same thing, but it didn't use
class_simple, did it?

> Anyway, it looks good, I only have one comment:
>
> > notebook:~# tree /sys/class/graphics/
> > /sys/class/graphics/
>
> "graphics"? Why that? Why not "fb"?
>
> It doesn't really matter to me, just curious.

It was discussed a while ago (this is James):

<quote>
On Tue, 9 Sep 2003, Benjamin Herrenschmidt wrote:
> > On Tue, 2003-09-09 at 21:24, Kronos wrote:
> > > +static struct class fb_class = {
> > > + .name = "video",
> >
> > I'd rather use "display" here. "video" is too broad and will cause
> > confusion with multimedia stuff.
>
> Exactly my comment. I was thinking about `graphics' instead of
> `video', but indeed `display' sounds better. Gr{oetje,eeting}s,

I prefere graphics myself. Display sounds to generic. That is what video
and graphics output is piped to. Since fbdev doesn't handle video ouput
normally this is kind of fuzzy sounding.
</quote>

Luca
--
Home: http://kronoz.cjb.net
"Di tutte le perversioni sessuali, la castita` e` la piu` strana".
Anatole France
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/