Re: [PATCH 070] NCR53C9x unused SCp.have_data_in

[Marcelo Tosatti]

On Mon, 22 Mar 2004, Geert Uytterhoeven wrote:

> NCR53C9x: Remove unused initialization of SCp.have_data_in (from Maciej W.
> Rozycki). This affects the following drivers:
>   - Amiga Oktagon SCSI
>   - DECstation SCSI
>
> The change for DECstation SCSI sneaked in through a MIPS update.
>
> --- linux-2.4.26-pre5/drivers/scsi/NCR53C9x.c	Sat Aug 17 14:10:41 2002
> +++ linux-m68k-2.4.26-pre5/drivers/scsi/NCR53C9x.c	Wed Jan 22 12:07:13 2003
> @@ -917,7 +917,7 @@
>  		if (esp->dma_mmu_get_scsi_one)
>  			esp->dma_mmu_get_scsi_one(esp, sp);
>  		else
> -			sp->SCp.have_data_in = (int) sp->SCp.ptr =
> +			sp->SCp.ptr =
>  				(char *) virt_to_phys(sp->request_buffer);
>  	} else {
>  		sp->SCp.buffer = (struct scatterlist *) sp->buffer;
> --- linux-2.4.26-pre5/drivers/scsi/oktagon_esp.c	Mon Apr  1 13:02:02 2002
> +++ linux-m68k-2.4.26-pre5/drivers/scsi/oktagon_esp.c	Wed Jan 22 12:07:17 2003
> @@ -548,7 +548,7 @@
>
>  void dma_mmu_get_scsi_one(struct NCR_ESP *esp, Scsi_Cmnd *sp)
>  {
> -        sp->SCp.have_data_in = (int) sp->SCp.ptr =
> +        sp->SCp.ptr =
>                  sp->request_buffer;
>  }

Can't we live with this?

Is removing it fixing any problem?

Yes, I'm being picky.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/