Re: [PATCH] Re: [linux-usb-devel] Re: [OOPS] reproducible oops with2.6.5-rc2-bk3

[Alan Stern]

On Thu, 25 Mar 2004, Colin Leroy wrote:

> Hi, 
> 
> Found out !
> cdc-acm wants both interfaces to be ready (cur_altsetting initialized) when acm_probe() is called. Hence, we have to make two parts out of the loop in message.c::usb_set_configuration(): one to init things, one to register them. 
> 
> The attached patch does that. It fixes the oops, and doesn't break any of my USB peripheral (printer, scanner, mouse, and diskonkey).
> 
> I hope it's fine enough to go in :)

It's obvious once you see the problem, isn't it?

Duncan Sands found exactly the same problem and the same solution a few 
months ago, but it was never added in.

In this case, your patch could be improved by calling device_initialize()  
during the first loop and device_add() during the second.  However, that
region of code is kind of in flux right at the moment.  When things settle
down, I promise to remember your change and make sure it gets in.

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/