Re: [PATCH-2.4.26] ip6tables cleanup

From: Peter Osterlund
Date: Sun Mar 28 2004 - 14:28:08 EST

Willy TARREAU <willy@xxxxxxxxx> writes:

> 2.4.26-rc1 returned this warning compiling ip6_tables :
> ip6_tables.c: In function `tcp_match':
> ip6_tables.c:1596: warning: implicit declaration of function `ipv6_skip_exthdr'
> I had to add a cast because ipv6_skip_exthdr() expects a 'struct sk_buff*' while
> its caller uses a 'const struct sk_buff*'. Here is a cleanup patch.

I think it would be better to change the ipv6_skip_exthdr() function
to take a const struct sk_buff* instead. Unnecessary casts are evil.

Peter Osterlund - petero2@xxxxxxxxx
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at