Re: [ Re: 2.6.5-rc2-aa vma merging]

From: Hugh Dickins
Date: Tue Mar 30 2004 - 00:28:52 EST

On Tue, 30 Mar 2004, Andrea Arcangeli wrote:
> On Mon, Mar 29, 2004 at 08:44:25PM +0100, Hugh Dickins wrote:
> > So I assume that what's there is needed, and the example below
> > does looks plausible enough: add page, fill it, protect it, ...
> this will work perfect, absolutely perfect. You didn't read my code well
> enough.

Sure, and I most certainly haven't read your future code well enough.
Your present implementation, one vma per page (in that real case where
vmas are properly merged by mainline or anonmm), is far from perfect.

anon_vma has surprised me more than once by working smoothly just
where I thought it must go wrong. Please do surprise me again:
write that code and post the patch which resolves this doubt.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at