Re: [PATCH] mask ADT: bitmap and bitop tweaks [1/22]
From: Paul Jackson
Date: Tue Mar 30 2004 - 03:59:17 EST
> No, the existing standard is to treat the unused bits as "don't cares".
> The difference codewise between the two choices is rather small anyway,
As you have documented in your requested patch to Andrew, the actual
code in 2.6.4 deviated from your intended bitmap model by the details
of cpus_equal(), cpus_empty() and cpus_weight() routines in
And 2.6.4 deviates from my bitmap model by a couple of *_complement
implementations and the multi-word CPU_MASK_ALL initializor.
By my model, the CPU_MASK_ALL code for large (multi word mask) systems
is missing the zero'ing of unused bits, in the (rare) case that the
number of valid bits in the mask was not an exact word multiple. And the
*_complement implementations routinely returned masks with the unused
bits set, given input with them not set.
Looking ahead to your next post - I suspect that my model is not the
zeroed tail invariant you describe. My bitmap model makes no promise to
zero out all input tails.
Rather my bitmap model adds the further implementation condition:
If input tails are zero, then output tails will be zero.
By your model, the CPU_MASK_ALL code for small (one word mask) systems
has some redundant code, to zero the unused bits. This CPU_MASK_ALL
could simply be "~0UL", not the more elaborate "(~((cpumask_t)0) >>
(8*sizeof(cpumask_t) - NR_CPUS))".
On further examination, I believe that your model better describes
what has been the design intent for bitmaps.
However my model conforms to yours. Any correct bitmap implementation
of my model is a correct implementation of yours. My model simply
adds the above condition on the implementation.
My change to zero out unused bits in the *_complement operators does not
violate your model. Nor does my change to zero out the unused bits in
the multi-word CPU_MASK_ALL initializor violate your model. You have
repeatedly emphasized that you don't care about the setting of these
bits. Surely you don't care if they are zero, just as you don't care
that the one word CPU_MASK_ALL initialization zeros the unused bits.
==> Note of course that the above model(s) are efforts to describe
the bitmap/bitop code. The model I provide for my new mask ADT is
different - it makes use of the implementation condition above on
bitmaps "Zero tails in yield zero tails out", along with an added
precondition "Don't pass in masks with nonzero tails" to avoid
needing much filtering code.
So - would you consent to my bundling the following changes as a single
patch - that adds to bitmaps the property that "output tails will be
zero if input tails are zero"?
1) Zero unused bits in the *_complement operators.
2) Zero unused bits in CPU_MASK_ALL (multiword).
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@xxxxxxx> 1.650.933.1373
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/