Re: [PATCH] Bind Mount Extensions 0.04.1 2/5

[Herbert Poetzl]

On Thu, Mar 18, 2004 at 12:16:50PM +0000, viro@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx wrote:
> On Mon, Mar 15, 2004 at 08:57:23AM +0100, Herbert Poetzl wrote:
> > -void update_atime(struct inode *inode)
> > +void update_atime(struct inode *inode, struct vfsmount *mnt)
> 
> _Hell_, no.  Proper solution is to move the callers upstream instead
> of propagating vfsmounts downstream.  That, BTW, was the main reason
> for readdir() patch.

# 04/03/18	viro@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx	1.1795.6.4
# [PATCH] add touch_atime() helper
# 
# Preparation for per-mountpoint noatime, nodiratime and later -
# per-mountpoint r/o.  Depends on file_accessed() patch, should go after
# it.
# 
# New helper - touch_atime(mnt, dentry).  It's a wrapper for
# update_atime() and that's where all future per-mountpoint checks will
# go.

static inline void touch_atime(struct vfsmount *mnt, struct dentry *dentry)
{
        /* per-mountpoint checks will go here */
        update_atime(dentry->d_inode);
}

Hum, so that is what you call 'moving the callers upstream'
instead of 'propagating vfsmounts downstream' ...

best,
Herbert

> BTW, update_atime() is exported.  And it's 2.6 now...
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/