Re: 2.6.4: disabling SCSI support not possible

[Russell King]

On Fri, Apr 02, 2004 at 02:21:40PM +0100, Sean Neakums wrote:
> Olaf Zaplinski <o.zaplinski@xxxxxxxxxxxxxxxxxxxxxx> writes:
> 
> > I cannot disable SCSI completely in 2.6.4's 'menuconfig'.
> 
> I believe that some kernel components require SCSI to be useful and so
> force SCSI to be activated.  One example that springs to mind is
> usb-storage.

usb-storage should depend on SCSI rather than forcing SCSI to be
enabled.

Using 'select' is all very well for the case where the target
configuration symbol is not user selectable, but in the case that
it is, it leads to the confusion shown above.

Maybe USB_STORAGE help text should say that it needs SCSI support?

Therefore, I propose this patch:

--- orig/drivers/usb/storage/Kconfig	Sat Mar 20 09:22:45 2004
+++ linux/drivers/usb/storage/Kconfig	Fri Apr  2 14:41:05 2004
@@ -4,8 +4,7 @@
 
 config USB_STORAGE
 	tristate "USB Mass Storage support"
-	depends on USB
-	select SCSI
+	depends on USB && SCSI
 	---help---
 	  Say Y here if you want to connect USB mass storage devices to your
 	  computer's USB port. This is the driver you need for USB floppy drives,
@@ -13,6 +12,9 @@ config USB_STORAGE
 	  similar devices. This driver may also be used for some cameras and
 	  card readers.
 
+	  Please select SCSI support before enabling USB Mass Storage
+	  support.
+
 	  To compile this driver as a module, choose M here: the
 	  module will be called usb-storage.
 

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/