Re: [PATCH] mask ADT: new mask.h file [2/22]

[Rusty Russell]

On Tue, 2004-04-06 at 16:45, Paul Jackson wrote:
> > That'd be a noop, I think.
> 
> Huh?

You passed the structs by value: you wanted to pass the address.

Linus dislikes typedefs for various reasons: if it's actually a struct
on some archs and not on others, he likes it.  Otherwise he historically
prefers the struct.  However, Linus is not the most reliable barometer.

Ingo added task_t because it make some lines fit in the sched.c code,
for example.  We removed list_t in 2.5.34.

I dislike typedefs because you have an extra name for something, and can
predeclare structs, which saves gratuitous header file inclusion.

Hope that clarifies,
Rusty.
-- 
Anyone who quotes me in their signature is an idiot -- Rusty Russell

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/