Re: [PATCH, local root on 2.4, 2.6?] compute_creds race

[Andy Lutomirski]

Chris Wright wrote:
> * Andy Lutomirski (luto@xxxxxxxxxxxxx) wrote:
>
> > The setuid program is now running with uid=euid=500 but full permitted 
> > capabilities.
>
>
> Yes, dropping and regaining the lock is asking for trouble.  Thank you for
> catching this.  I don't have an issue with changing the interface name.
> I guess the only question I have is if it's better to leave the setuid
> handling in the core, and move the newly named hook under the task_lock()?

I imagine some LSM might want to do something complex, and holding the 
task lock might become a problem.  Also, an LSM might want to change the 
setuid handling, and this makes it easier.

--Andy

> thanks,
> -chris
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/