Re: [PATCH 2.6] Class support for ppdev.c

From: Greg KH
Date: Sat Apr 10 2004 - 12:04:20 EST


On Sat, Apr 10, 2004 at 03:51:15PM +0200, Marcel Sebek wrote:
> This patch adds class support to ppdev.c.
>
> The module compiles and loads ok.

Looks good, but we really shoulnd't be duplicating the devfs
functionality here. We should only show the devices that the system
really has present, instead of always showing all of the devices. Care
to fix your patch up to implement this instead?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/