Re: Patch for usb-storage in 2.4 [linux-usb-devel]

From: Alan Stern
Date: Sun Apr 11 2004 - 10:48:00 EST


On Sat, 10 Apr 2004, Pete Zaitcev wrote:

> On Sat, 10 Apr 2004 17:09:57 -0700
> Matthew Dharm <mdharm-kernel@xxxxxxxxxxxxxxxxxx> wrote:
>
> > Was there a reason to add more do-nothing code to host_reset?
>
> Woopsie. I wanted to write it, but understood that if I return right
> code from "bus" reset, it should never be called. Sorry about that...
> I'll remove that part.

I haven't had time to look at your patch in any detail yet. But I did
notice the extra stuff in the host-reset path. It looks like you're
worrying about nothing -- the easiest thing to do would be to remove the
host-reset pointer from the host template. Then the SCSI error handler
would know that host resets aren't implemented and would never try to
carry them out.

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/