Re: [PATCH] conditionalize some boring buffer_head checks

[Andrew Morton]

Andrew Morton <akpm@xxxxxxxx> wrote:
>
>  buffer_error() was always supposed to be temporary.  Once per month someone
>  reports the one in __find_get_block_slow(), but that's all.  The only
>  reason for keeping it around is as a debug aid to filesystem developers.
> 
>  We could make it a no-op if !CONFIG_BUFFER_DEBUG.

But even if we do that, the compiler cannot optimise away things like:

	if (atomic_read(&bh->b_count) == 0 &&
			!PageLocked(bh->b_page) &&
			!PageWriteback(bh->b_page))
		do {} while (0);

so if it offends you, go kill the thing outright.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/